Deprecate SocketAddress-related methods #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ServerAddress#getSocketAddress * ServerAddress#getSocketAddresses * UnixServerAddress#getUnixSocketAddress JAVA-4940
jyemin
commented
Sep 6, 2023
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
This one seems similar enough to also deprecate at the same time
| @@ -44,14 +44,18 @@ public UnixServerAddress(final String path) { | |||
| isTrueArgument("The path must end in .sock", path.endsWith(".sock")); | |||
| } | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
I'm not sure why the warning also has to be suppressed here, but it complains if I don't
There was a problem hiding this comment.
It's probably because of the -Xlint:deprecation lint: the method overrides a deprecated method.
stIncMale
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4940
When we actually remove these methods and replace with some private helper, and also remove
StreamFactoryfrom API, we'll be able to remove theServerAddressWithResolverclass and just pass theInetAddressResolverwherever it needs to be available.