New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port transactions spec tests to unified format #1310
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
05fc373
Port legacy transactions specification tests to the unified format
jyemin 7fe8499
Also retry create if interrupted
jyemin 5fe2bd6
Enhance error matcher to handle other exception types
jyemin f735e2f
checkstyle
jyemin a9b538b
Add comments
jyemin 9c36545
Remove inspection suppression
jyemin 5773770
checkstyle
jyemin 3cc70b7
Apply suggestion
jyemin f3a6844
Merge branch 'master' into j4171
jyemin 829b0aa
Move killAllSessions earlier in setup
jyemin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
220 changes: 0 additions & 220 deletions
220
driver-core/src/test/resources/transactions-convenient-api/README.rst
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On sharded clusters < 4.2,
drop
sometimes fails on the first try with a write concern error. Trying again works around it. Same forcreate
below, except with a different exception. :(I'm curious whether other drivers will run into this. I imagine they will and if so a DRIVERS ticket is probably in order. What do you think @jmikola ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall encountering a PHPLIB build failure for
drop
orcreate
in this context. If you want to open a DRIVERS ticket, I'd suggest including the server errors in the description and immediately opening a specs PR with the desired clarification while this is still fresh on your mind.