Simplify DefaultConnectionPool.OpenConcurrencyLimiter.tryLock
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
force-pushed
the
JAVA-3927_simplify
branch
from
fed5c85
to
5971c21
Compare
stIncMale
force-pushed
the
JAVA-3927_simplify
branch
from
5971c21
to
cca5b0e
Compare
jyemin
reviewed
Apr 29, 2021
driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java
Show resolved
Hide resolved
stIncMale
force-pushed
the
JAVA-3927_simplify
branch
from
cca5b0e
to
09b3f3f
Compare
jyemin
requested changes
Apr 30, 2021
driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DefaultConnectionPool.java
Outdated
Show resolved
Hide resolved
@jyemin Now that you know there is a commit message, is this request still actual? |
When locking for the purpose of using the wait/signal approach, one does not have to account the time spent acquiring the lock towards the timeout. While doing so may reduce the non-deterministic duration by which a timeout is exceeded by any implementation of a timeout, such overtime is usually negligible, unless the lock is highly contended and/or checking the condition before starting to wait is time-consuming. The Java SE example for `java.util.concurrent.locks.Condition.awaitNanos` ignores the time spent acquiring the lock. Doing so potentially reduces responsiveness to timeouts, but does not affect other performance characteristics, so I believe such simplification is worth it and I should have taken this path initially. JAVA-3927
stIncMale
force-pushed
the
JAVA-3927_simplify
branch
from
d1d9ad4
to
3bce9e7
Compare
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
…odb#702) When locking for the purpose of using the wait/signal approach, one does not have to account the time spent acquiring the lock towards the timeout. While doing so may reduce the non-deterministic duration by which a timeout is exceeded by any implementation of a timeout, such overtime is usually negligible, unless the lock is highly contended and/or checking the condition before starting to wait is time-consuming. The Java SE example for `java.util.concurrent.locks.Condition.awaitNanos` ignores the time spent acquiring the lock. Doing so potentially reduces responsiveness to timeouts, but does not affect other performance characteristics, so I believe such simplification is worth it and I should have taken this path initially. JAVA-3927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: rebase on top of
masterafter merging #699, then request for review.JAVA-3927