Update netty dependencies to use the netty-bom #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same failure with tcnative. The BOM is pulling in 2.0.53, so that version doesn't work either. So we have to roll back somewhere between 48 and 52 unless we can figure out why. |
jyemin
reviewed
Aug 23, 2022
| testRuntimeOnly "io.netty:netty-tcnative-boringssl-static" | ||
|
|
||
| classifiers.forEach { | ||
| testRuntimeOnly "io.netty:netty-tcnative-boringssl-static::$it" |
There was a problem hiding this comment.
So we add them all and the correct one gets picked at runtime? Nice.
jyemin
approved these changes
Aug 23, 2022
ispringer
pushed a commit
to evergage/mongo-java-driver
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4710