PHPC-487: Fix return value comparison in check_closed stream handler #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can I suggest another test which actually results in the opposite, e.g. the stream being gone away? The reporter said he got empty exception, which I'm guessing is because it wasn't true -- but we need a testcase that makes sure we get a real exception if the stream is closed and no connection is therefore available. |
Will get on that 👍 |
|
Any news on this? |
The return value of the check_closed handler is true if the stream is closed.
jmikola
force-pushed
the
phpc-487
branch
3 times, most recently
from
e2e9a61
to
ae96932
Compare
bug0487-001.phpt was contributed by @prolic in mongodb#132
jmikola
added a commit
that referenced
this pull request
Dec 2, 2015
This was referenced Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-487
Fixes #132 and supersedes #134.