New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-2970 Prioritize electionId over setVersion for stale primary check on 6.0+ #1067

Merged

ShaneHarvey merged 2 commits into mongodb:master from ShaneHarvey:PYTHON-3400

Oct 5, 2022

Member

ShaneHarvey commented Oct 3, 2022

This PR:

Implements PYTHON-2970 by reapplying the original change from PYTHON-2970 SDAM should give priority to electionId over setVersion to detect a stale primary #845.
Implements PYTHON-3400 to only use the new logic on MongoDB 6.0+

ShaneHarvey added 2 commits

September 29, 2022 14:27


          PYTHON-2970 Prioritize electionId over setVersion for stale primary c…

cf2e687

…heck (mongodb#845)


          PYTHON-3400 Only use new electionId/setVersion logic on 6.0+

f513533

ShaneHarvey requested review from blink1073 and juliusgeo as code owners

October 3, 2022 22:12

blink1073 approved these changes

View reviewed changes

Member

blink1073 left a comment

LGTM!

ShaneHarvey merged commit 85f0987 into mongodb:master

ShaneHarvey deleted the PYTHON-3400 branch

October 6, 2022 21:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment