Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-2970 SDAM should give priority to electionId over setVersion to detect a stale primary #845

Merged
merged 4 commits into from
Mar 9, 2022
Merged

PYTHON-2970 SDAM should give priority to electionId over setVersion to detect a stale primary #845

merged 4 commits into from
Mar 9, 2022

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Feb 4, 2022 •
edited
Loading

Draft implementation of DRIVERS-1954: mongodb/specifications#1122

TODO:

  • ServerDescription.election_tuple is now incorrect. Ideally we'd reverse it but doing so would be a breaking change. Perhaps we should just deprecate it? Edit: I opened https://jira.mongodb.org/browse/PYTHON-3162 to deprecation this.

@blink1073
Copy link
Member

Perhaps we should just deprecate it?

Makes sense to me

@ShaneHarvey ShaneHarvey marked this pull request as ready for review March 8, 2022 23:27
blink1073
blink1073 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit 225d131 into mongodb:master Mar 9, 2022
@ShaneHarvey ShaneHarvey deleted the PYTHON-2970 branch March 10, 2022 22:13
ShaneHarvey added a commit that referenced this pull request Mar 10, 2022
@ShaneHarvey
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
52d7795 
…heck (#845)

(cherry picked from commit 225d131)
ShaneHarvey added a commit that referenced this pull request Mar 29, 2022
@ShaneHarvey
Revert "PYTHON-2970 Prioritize electionId over setVersion for stale p…
a4bba9d 
…rimary check (#845)"

This reverts commit 225d131.
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 5, 2022
@ShaneHarvey @juliusgeo
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
023a73a 
…heck (mongodb#845)
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 5, 2022
@ShaneHarvey @juliusgeo
Revert "PYTHON-2970 Prioritize electionId over setVersion for stale p…
206e43b 
…rimary check (mongodb#845)"

This reverts commit 225d131.
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 6, 2022
@ShaneHarvey @juliusgeo
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
1bc3182 
…heck (mongodb#845)
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 6, 2022
@ShaneHarvey @juliusgeo
Revert "PYTHON-2970 Prioritize electionId over setVersion for stale p…
8fb26cb 
…rimary check (mongodb#845)"

This reverts commit 225d131.
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
@ShaneHarvey @juliusgeo
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
f55777a 
…heck (mongodb#845)
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
@ShaneHarvey @juliusgeo
Revert "PYTHON-2970 Prioritize electionId over setVersion for stale p…
fed5176 
…rimary check (mongodb#845)"

This reverts commit 225d131.
ShaneHarvey added a commit to ShaneHarvey/mongo-python-driver that referenced this pull request Sep 29, 2022
@ShaneHarvey
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
cf2e687 
…heck (mongodb#845)
@ShaneHarvey ShaneHarvey mentioned this pull request Oct 3, 2022
Merged
ShaneHarvey added a commit that referenced this pull request Oct 5, 2022
@ShaneHarvey
PYTHON-2970 Prioritize electionId over setVersion for stale primary c…
64d7d6d 
…heck (#845)
ShaneHarvey added a commit that referenced this pull request Oct 5, 2022
@ShaneHarvey
Revert "PYTHON-2970 Prioritize electionId over setVersion for stale p…
ab9ca27 
…rimary check (#845)"

This reverts commit 52d7795.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ShaneHarvey @blink1073