PYTHON-2963 Add tox config in preparation for migration from setup.py #1240
Conversation
| [tox] | ||
| requires = | ||
| tox>=4 | ||
| envlist = |
There was a problem hiding this comment.
The lack of specified Python versions here will cause tox to run using the default system interpreter.
tox.ini
Outdated
| commands = | ||
| pre-commit run --all-files | ||
| pre-commit run --all-files --hook-stage manual flake8 | ||
| pre-commit run --all-files --hook-stage manual doc8 |
There was a problem hiding this comment.
pre-commit run --all-files --hook-stage manual will run all the pre-commit checks in one command.
There was a problem hiding this comment.
Good catch, thanks!
NoahStapp
changed the title
|
Note that moving our evergreen tests to |
Sure, will do. |
For all of the workflow jobs? |
|
I think just the |
| echo '{"strict": ["tests/test_typing_strict.py"]}' >> pyrightconfig.json | ||
| pyright test/test_typing_strict.py | ||
|
|
||
| [testenv:typecheck] |
There was a problem hiding this comment.
I don't think we need this environment, we can call the individual ones.
There was a problem hiding this comment.
This is intended to replace needing an alias to run all of the typechecks in a single command.
There was a problem hiding this comment.
Hmm, it is possible then to compose this to use the deps and commands of the other envs?
There was a problem hiding this comment.
Figured it out, fixed!
tox.ini
Outdated
| {[testenv:typecheck-pyright]deps} | ||
| allowlist_externals=echo | ||
| commands = | ||
| echo '{"strict": ["tests/test_typing_strict.py"]}' >> pyrightconfig.json |
There was a problem hiding this comment.
>> should be > IIUC. Otherwise we'd repeatedly append to the same file.
This change is still using
python setup.py testinside tox to run the unit tests: migration to pytest will be done in https://jira.mongodb.org/browse/PYTHON-3727, and migration to pyproject.toml will be done in https://jira.mongodb.org/browse/PYTHON-2965.