RUBY-1562 Remove -1 limit in db view #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
force-pushed
the
remove-db-view-limit
branch
7 times, most recently
from
0cfb2fc
to
926103b
Compare
p-mongo
changed the title
p-mongo
force-pushed
the
remove-db-view-limit
branch
3 times, most recently
from
a0bf312
to
e037bb7
Compare
As far as I can tell the -1 limit is ignored by the driver, just like a nil limit would be ignored. However the call on server is problematic with the new retryable reads API since server may change during a read operation.
p-mongo
force-pushed
the
remove-db-view-limit
branch
from
e037bb7
to
6fb822e
Compare
p-mongo
changed the title
saghm
reviewed
Mar 29, 2019
|
Existing code changes what command is sent to the server based on the server the command is (going to) be sent to. With retryable reads, the server for a retry may be different than the server for the first attempt, in particular server version may change. Thus the command that was constructed for the first server may not be appropriate for the second server. Luckily, as far as I can tell the limit of -1 is no different from limit being nil, thus this PR removes the limit being set to -1 in some circumstances. |
saghm
approved these changes
Mar 29, 2019
p-mongo
pushed a commit
to p-mongo/mongo-ruby-driver
that referenced
this pull request
Mar 29, 2019
* master: RUBY-1562 Remove -1 limit in db view (mongodb#1334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the -1 limit is ignored by the driver, just like
a nil limit would be ignored. However the call on server is problematic
with the new retryable reads API since server may change during a
read operation.