Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUBY-1784 Document that retryable writes are now on by default #1338

Merged
merged 2 commits into from Apr 9, 2019

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Apr 4, 2019

No description provided.

@p-mongo p-mongo changed the title RUBY-1784 Document that retryable writes are now on by default RUBY-1784 Document that retryable writes are now on by default Apr 4, 2019
@p-mongo p-mongo marked this pull request as ready for review April 5, 2019 19:52
@p-mongo p-mongo requested a review from saghm April 5, 2019 21:04

The following write methods used in day-to-day operations on collections will
be automatically retried:
As of driver version 2.9.0, the modern mechanism is used by default, and the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding correctly that on server versions below 3.6 will have no retryable writes (either modern or legacy) by default, and legacy retryable writes will only be enabled on those servers if the retryWrites: false option is specified? It's not super clear to me from the changes in the documentation whether this is the case or if legacy retryable writes are enabled by default for older servers still, so I think we should explicitly state whichever way it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct, what would you suggest as more clear language?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the sentence to "As of driver version 2.9.0, the modern mechanism is used by default on servers that support it, and the legacy mechanism is deprecated and disabled by default on all server versions."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, made this change.

@p-mongo p-mongo merged commit 68c1fa7 into mongodb:master Apr 9, 2019
@p-mongo p-mongo deleted the 1784 branch April 9, 2019 15:59
p-mongo pushed a commit to p-mongo/mongo-ruby-driver that referenced this pull request Apr 9, 2019
* upstream/master:
  RUBY-1784 Document that retryable writes are now on by default (mongodb#1338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants