New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUBY-1784 Document that retryable writes are now on by default #1338
Conversation
|
||
The following write methods used in day-to-day operations on collections will | ||
be automatically retried: | ||
As of driver version 2.9.0, the modern mechanism is used by default, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding correctly that on server versions below 3.6 will have no retryable writes (either modern or legacy) by default, and legacy retryable writes will only be enabled on those servers if the retryWrites: false
option is specified? It's not super clear to me from the changes in the documentation whether this is the case or if legacy retryable writes are enabled by default for older servers still, so I think we should explicitly state whichever way it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, what would you suggest as more clear language?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the sentence to "As of driver version 2.9.0, the modern mechanism is used by default on servers that support it, and the legacy mechanism is deprecated and disabled by default on all server versions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, made this change.
* upstream/master: RUBY-1784 Document that retryable writes are now on by default (mongodb#1338)
No description provided.