RUBY-1811 ChangeStream spec's Resumable Error definition is too broad #1375
Conversation
lib/mongo/error/operation_failure.rb
Outdated
| @@ -162,6 +168,16 @@ def change_stream_resumable_code? | |||
| end | |||
| private :change_stream_resumable_code? | |||
|
|
|||
| def change_stream_resumable_label? | |||
There was a problem hiding this comment.
This method would return true when there is no label, which I think is confusing. Can it be changed to change_stream_not_resumable_label? which would return true if 1) there is a label and 2) it is a change stream not resumable one?
lib/mongo/error/operation_failure.rb
Outdated
| @@ -162,6 +168,16 @@ def change_stream_resumable_code? | |||
| end | |||
| private :change_stream_resumable_code? | |||
|
|
|||
| def change_stream_resumable_label? | |||
| if labels | |||
| !labels.include? CHANGE_STREAM_NOT_RESUME_LABEL | |||
There was a problem hiding this comment.
Since this is the only use of the constant, the literal can be given inline.
spec/support/change_streams.rb
Outdated
| @@ -165,8 +177,12 @@ def match_result?(result) | |||
| end | |||
|
|
|||
| def match_commands?(actual) | |||
| @expectations.each_with_index.all? do |e, i| | |||
| actual[i] && match?(e, actual[i]) | |||
| if @expectations | |||
There was a problem hiding this comment.
I would prefer this condition be given in the spec test rather than in the matcher.
Example 1: https://github.com/mongodb/mongo-ruby-driver/blob/master/spec/spec_tests/uri_options_spec.rb#L54
Example 2: https://github.com/mongodb/mongo-ruby-driver/blob/master/spec/support/crud.rb#L153 (the crud tests have a bit more than usual meta programming around them)
|
Unfortunately we now have a bunch of other test failures. |
HanaPearlman
force-pushed
the
resumable-error-def
branch
from
a92f36a
to
a21aa04
Compare
HanaPearlman
force-pushed
the
resumable-error-def
branch
from
a21aa04
to
459d954
Compare
No description provided.