Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUBY-1563 Poll SRV records for mongos discovery #1441

Merged
merged 8 commits into from
Sep 12, 2019
Merged

RUBY-1563 Poll SRV records for mongos discovery #1441

merged 8 commits into from
Sep 12, 2019

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Jul 13, 2019 •
edited
Loading

No description provided.

@p-mongo p-mongo changed the title RUBY-1563 Support polling SRV records for mongos discovery wip RUBY-1563 Support polling SRV records for mongos discovery Jul 15, 2019
@p-mongo p-mongo changed the title wip RUBY-1563 Support polling SRV records for mongos discovery RUBY-1563 Support polling SRV records for mongos discovery Jul 17, 2019
@p-mongo p-mongo changed the title RUBY-1563 Support polling SRV records for mongos discovery wip RUBY-1563 Support polling SRV records for mongos discovery Jul 17, 2019
@p-mongo p-mongo force-pushed the 1563 branch 4 times, most recently from 24e852d to 25044fd Compare July 24, 2019 04:11
@p-mongo p-mongo force-pushed the 1563 branch 3 times, most recently from 0e4e02a to cfc0d79 Compare July 25, 2019 21:55
@p-mongo p-mongo changed the title wip RUBY-1563 Support polling SRV records for mongos discovery RUBY-1563 Poll SRV records for mongos discovery Sep 6, 2019
egiurleo
egiurleo reviewed Sep 11, 2019
View reviewed changes
spec/integration/reconnect_spec.rb
@@ -3,7 +3,7 @@
describe 'Client after reconnect' do
let(:client) { authorized_client }

it 'works' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

egiurleo
egiurleo approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tests!

@p-mongo p-mongo merged commit 485ee7b into mongodb:master Sep 12, 2019
@p-mongo p-mongo deleted the 1563 branch September 12, 2019 15:43
@p-mongo p-mongo mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@p-mongo @egiurleo @saghm @p