Fix RUBY-1898 Socket reads may raise Timeout::Error #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
…feres with assertions
HanaPearlman
approved these changes
Aug 9, 2019
p-mongo
added a commit
that referenced
this pull request
Aug 9, 2019
* RUBY-1898 Correctly map select timeouts to Mongo::Error::TimeoutError * RUBY-1898 Handle IO::WaitWritable when reading * RUBY-1898 Raise more informative exceptions * RUBY-1898 Rewrite the code to avoid weird failures * Separate contexts to avoid unintentional connection reuse * RUBY-1898 Handle IO::WaitWritable when reading * Close all clients before * Remove default 5 legacy read retries in the test suite since it interferes with assertions * Remove all read retries for the connection timeout test * Remove unneeded line * Remove obsolete IO::WaitWritable rescue
p-mongo
added a commit
that referenced
this pull request
Aug 13, 2019
* RUBY-1898 Correctly map select timeouts to Mongo::Error::TimeoutError * RUBY-1898 Handle IO::WaitWritable when reading * RUBY-1898 Raise more informative exceptions * RUBY-1898 Rewrite the code to avoid weird failures * Separate contexts to avoid unintentional connection reuse * RUBY-1898 Handle IO::WaitWritable when reading * Close all clients before * Remove default 5 legacy read retries in the test suite since it interferes with assertions * Remove all read retries for the connection timeout test * Remove unneeded line * Remove obsolete IO::WaitWritable rescue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/RUBY-1898