Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUBY-2213 Rename sdam spec runner & move spec runner requires to the spec tests #1908

Merged
merged 2 commits into from May 18, 2020
Merged

RUBY-2213 Rename sdam spec runner & move spec runner requires to the spec tests #1908

merged 2 commits into from May 18, 2020

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented May 16, 2020 •
edited

https://jira.mongodb.com/browse/RUBY-2213

  • Rename server_discovery_and_monitoring.rb to sdam.rb for consistency with other code implementing sdam.
  • Move spec runner requires into spec tests that need them to lighten the lite spec helper.

@p-mongo p-mongo force-pushed the 2213-2 branch 2 times, most recently from 7fc3a23 to 0d2c627 Compare May 18, 2020 04:06
@p-mongo p-mongo changed the title RUBY-2213 Move spec runner requires to the spec tests RUBY-2213 Rename sdam spec runner & move spec runner requires to the spec tests May 18, 2020
@p-mongo p-mongo requested a review from egiurleo May 18, 2020 15:45
@p-mongo p-mongo merged commit 177d08f into mongodb:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@p-mongo @egiurleo @p