Added support for keeping a specified amount of documents in GridFS instead of removing all or none #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed the delete_old option. The delete_old removed all the old files while having a versioning system you might want to keep a limited set of files. This small little patch does that. You can specify a number of versions to keep by using the new versions option.
|
This is a good idea, but a couple of notes:
|
…ns option on GridFilesystem.
|
I've added back support for the :delete_old option, added a testcase and documented the option in the description of the method. |
|
This looks good. Many thanks! |
banker
added a commit
that referenced
this pull request
Feb 16, 2012
Allow GridFileSystem#delete to keep a specified number of versioned documents in GridFS rather than removing all or none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small enhancement for GridFS.open method.
The delete_old option removed all the old files while having a versioning system you might want to keep a limited set of files. This small little patch does that. You can specify a number of versions to keep by using the new versions option.
More information on why and how to use:
http://techblog.floorplanner.com/2011/12/28/mongodb-and-gridfs-versioning/