SWIFT-1129 Create full stack Swift example project #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Mar 4, 2022
| do { | ||
| try await body() | ||
| } catch { | ||
| print("Unexpected error: \(error)") |
There was a problem hiding this comment.
@am-MongoDB I was wondering if you could suggest a good lightweight way to handle errors that occur when interacting with the back end. I didn't want to do anything too complicated, but printing also seems maybe too simple... thoughts?
There was a problem hiding this comment.
I'll suggest some changes to the Views to show errors
|
@am-MongoDB I don't seem to be able to formally request you as a reviewer due to repo permissions, but let me know if GitHub will still let you leave comments or not. |
patrickfreed
reviewed
Mar 8, 2022
Examples/FullStackSwiftExample/Models/Sources/Models/Models.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel Atkinson <isabel.atkinson@mongodb.com>
kmahar
force-pushed
the
SWIFT-1129/iOS-example
branch
from
531976e
to
8718047
Compare
am-MongoDB
suggested changes
Mar 14, 2022
| do { | ||
| try await body() | ||
| } catch { | ||
| print("Unexpected error: \(error)") |
There was a problem hiding this comment.
I'll suggest some changes to the Views to show errors
Examples/FullStackSwiftExample/iOSApp/Kittens/ViewModels/AddKittenViewModel.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/ViewModels/ViewUpdateDeleteKittenViewModel.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/ViewModels/ViewUpdateDeleteKittenViewModel.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/ViewModels/ViewUpdateDeleteKittenViewModel.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/Views/AddKitten.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/Views/KittenList.swift
Outdated
Show resolved
Hide resolved
Examples/FullStackSwiftExample/iOSApp/Kittens/Views/ViewUpdateDeleteKitten.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Morgan <andrew.morgan@mongodb.com>
Co-authored-by: Andrew Morgan <andrew.morgan@mongodb.com>
Co-authored-by: Andrew Morgan <andrew.morgan@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-1129