TOOLS-2708: Atlas recommended connection string for mongostat doesn't work #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan-Mongo
suggested changes
Sep 17, 2020
tfogo
requested changes
Sep 23, 2020
varsha804
force-pushed
the
TOOLS-2708
branch
from
3c20028
to
be5908c
Compare
|
Updated manual testing: |
tfogo
requested changes
Sep 29, 2020
| @@ -596,6 +596,20 @@ func (opts *ToolOptions) setOptionsFromURI(cs connstring.ConnString) error { | |||
| return ConflictingArgsErrorFormat("host", strings.Join(cs.Hosts, ","), opts.Host, "--host") | |||
| } | |||
| } | |||
| } else if len(cs.Hosts) > 0 { | |||
| hostPort := strings.Split(cs.Hosts[0], ":") | |||
| opts.Host = hostPort[0] | |||
There was a problem hiding this comment.
So I think we have to loop through cs.Hosts and construct a comma separated list of the hosts without ports for opts.Host. Also if cs.ReplicaSet is set, we should prepend <replSet>/ to the list.
It looks like util.CreateConnectionAddrs() expects a comma separated list of hosts so we need to make sure we set it correctly here.
There was a problem hiding this comment.
Oh I didn't see your question about this on the mtc PR - I'll respond there.
| opts.Host = hostPort[0] | ||
|
|
||
| // a port might not be specified, e.g. `mongostat --discover` | ||
| if len(hostPort) == 2 { |
There was a problem hiding this comment.
Good check, we should do this for each of the elements of cs.Hosts.
tfogo
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection string failure seems to be a result of this code change. Since
opts.Portandopts.Hostare not set when a user only uses--uri,fullhostgets set tolocalhost:27017, thereby incorrectly rewriting the hostname tolocalhost.Manual testing:
--discoverwithout a connection string--uri