Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS-2849 fix resharding tests #385

Merged
merged 2 commits into from
Jul 7, 2021
Merged

TOOLS-2849 fix resharding tests #385

merged 2 commits into from
Jul 7, 2021

Conversation

tfogo
Copy link
Member

@tfogo tfogo commented Jul 6, 2021

The resharding tests were failing on standalones because they require a replica set to test the oplog. These tests now skip standalones.

The test was also flaking on replica sets due to the timing between creating and dropping the collections in the test. I have modified the timing and it looks like it no longer flakes.

Evergreen patch: https://spruce.mongodb.com/version/60e4d55fe3c3312642105c74/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@tfogo tfogo requested a review from huan-Mongo July 6, 2021 23:14
Copy link
Contributor

@huan-Mongo huan-Mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tfogo tfogo merged commit a6b0cdb into master Jul 7, 2021
@tfogo tfogo deleted the fix-resharding branch July 7, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants