Skip to content

Commit

Permalink
Import wiredtiger: 187983a50c696eb217a780bb6b29e4bd3433c13b from bran…
Browse files Browse the repository at this point in the history
…ch mongodb-4.4

ref: 7e595e4a3a..187983a50c
for: 4.4.0-rc0

WT-3821       Python test case fails due to pinned timestamp warning
WT-4458       Only sweep btree handles that have been evicted from cache
WT-4671       Remove Limbo pages
WT-4674       Instantiate birthmark records using in-memory metadata
WT-4676       Search LAS for the history and compare to in-memory update
WT-4677       Re-initialize prepared updates
WT-4678       Write the test workload for relevant history in cache
WT-4681       Check if expired content is being swept from lookaside
WT-4683       Reverse the modifies when writing to LAS
WT-4685       Add new statistics for relevant history in cache
WT-4868       Aggregate btree write gen from leaf pages in salvage
WT-4954       Document duplicate backup cursors
WT-5001       Migrate Jenkins “wiredtiger-test-format-stress-sanitizer-ppc” job to Evergreen
WT-5045       Add more statistics tracking where checkpoint spends time
WT-5052       Enhance lookaside search functionality to handle WT_MODIFY records
WT-5058       Stop initializing a page with updates from lookaside
WT-5066       Extend test_las06 to support column store.
WT-5072       Modify __wt_rec_upd_select() to pull an update from lookaside
WT-5073       Review update chain traversals
WT-5089       test_las02.py fails: Unable to locate the correct record
WT-5092       Modify lookaside schema to add timestamp and transaction id to the key
WT-5098       Modify __wt_update_alloc() to accept NULL WT_ITEM values
WT-5141       Handle multiple modifies for the same key on lookaside eviction
WT-5146       Returning wrong record value for variable length columnar table
WT-5158       Remove assertion in __wt_find_lookaside_upd for cursor comparison
WT-5167       Fixing the missing pieces of page instantiation from las
WT-5186       Handle reading of LAS modifies on top of a birthmark record
WT-5191       Avoid LAS sweep server remove records that don't have disk image with proper version
WT-5203       lookaside history should no longer be preferentially evicted
WT-5212       Backup data validation tests
WT-5214       Verify potential incremental failures
WT-5215       Stress testing of incremental backup
WT-5222       Make checkpoint always choose skew newest
WT-5225       Create persistent file for History store
WT-5227       Enable python test cursor04 on relevant history feature branch
WT-5228       Several tests fail with incorrect or missing record after reconciliation changes
WT-5233       Prepared update not visible in las06
WT-5236       Enhance workgen to support draft lookaside stress workload
WT-5246       Update WiredTiger backup documentation
WT-5253       Add History store file to checkpoint target list.
WT-5254       Add aggregate timestamp info to the WT_REF.
WT-5256       Fix relevant history build after develop merged brought LIMBO reference
WT-5264       Add a delete record for every insert record into the WT history store to represent stop time pair
WT-5267       Enable storing start/stop time pair for each record in the history store
WT-5271       Remove WT_PAGE_LOOKASIDE structure.
WT-5279       Disable failing tests in the preferred way
WT-5280       Write all other versions to history store during checkpoint.
WT-5281       Assert that we're no longer writing tombstones to the history store
WT-5283       Eviction to create disk image with newest committed version.
WT-5284       Test to check eviction is writing the newest version to data store
WT-5286       Enable the data format to store time pair
WT-5289       Remove the code that does garbage collection from sweep server
WT-5290       Add new verbose flag and verbose logs for checkpoint garbage collection
WT-5291       Additional statistics for checkpoint garbage collection
WT-5292       Test the garbage collection by checkpoint
WT-5295       Disable remaining failing tests in durable history branch
WT-5298       Add a condition to verify the timestamp of a page during checkpoint of history store
WT-5300       Traverse the history store internal page for obsolete child pages by checkpoint
WT-5302       Begin writing validity window for new data format
WT-5303       Update checkpoint statistics for the new history store file.
WT-5308       Remove WT --enable-page-version-ts build configuration option
WT-5317       Eviction writes uncommitted metadata changes to disk
WT-5320       Save update restore to reuse lookaside eviction.
WT-5321       Update the stats and counters that represent lookaside inserts according to durable history
WT-5328       Evict obsolete history store page
WT-5333       Fix search not found issue due to skipped birthmark and rework txn_read
WT-5335       Read the start and stop time pairs back from cell when we reconstruct it on update chain
WT-5341       Clang sanitiser was triggered by checkpoint writing to the history store change
WT-5343       Show history store in the wt list
WT-5345       Show aggregated timestamp information for internal pages and leaf pages
WT-5347       Add ability for wt util to print historical versions of a key
WT-5353       Verify data continuity between history and data store
WT-5354       Verify history store key is not missing from the data store
WT-5355       Add the ability to dump a given btree as of a timestamp
WT-5361       Fix selecting aborted txn to write to disk
WT-5369       Don't use transaction ids from a page with a previous startup generation
WT-5385       Use WT_UPDATE_HISTORY_STORE to avoid repeatedly inserting updates to lookaside
WT-5386       Re-enable test_inmem01
WT-5388       Fix write squash statistic caused by change in reverse delta
WT-5392       Fall out of in-memory obsolete history page eviction
WT-5414       Change the usage from durable timestamp to commit timestamp during eviction.
WT-5416       Make sure that rollback to stable works on all objects in WT
WT-5417       Skip the clean pages of each tree with aggregated stop timestamp is less than stable timestamp
WT-5419       Create a TOMBSTONE update to represent the on-disk value state
WT-5420       Reconcile should consider TOMBSTONE update to replace or remove the on-disk value
WT-5421       Search the history store to find the value that can be replaced the on-disk value
WT-5422       Remove the history updates for reconciled data pages
WT-5423       Convert a history store modified value into a full update
WT-5424       Add statistics for rollback to stable operations
WT-5425       Add a new verbose flag to print the rollback to stable operation
WT-5426       Ensure rollback to stable is executed from recovery
WT-5427       Implement tests for rollback to stable
WT-5431       Merge develop branch to durable history branch
WT-5434       Remove develop-timestamp and add test for 4.0 and 4.2 pair to compatibility_test_for_mongodb_releases.sh after merge durable history to develop
WT-5441       Fix known visibility issues
WT-5446       Fix not writing to lookaside
WT-5448       Reconciliation wrongly overwrites the cell with default time pairs
WT-5451       Update reverse modify logic to always insert a modify into the history store
WT-5453       Fix cell packing for globally visible values.
WT-5454       Rename cache_overflow configuration option.
WT-5455       Fix test_hs03.py
WT-5457       single block reconciliation with saved updates can leak blocks
WT-5461       Search should not return onpage value if nothing is found by transaction read
WT-5462       Rebalance the Evergreen Python test buckets
WT-5464       Open reading history cursors on the user session
WT-5467       Make history store cursor part of each session, get rid of the cursor pool
WT-5469       Support mixing timestamped and non-timestamped updates
WT-5476       Continue writing tombstones when the tombstone is globally visable.
WT-5478       Insert records directly into history store without a txn
WT-5482       Increment cache usage when appending on-disk value to update list
WT-5484       Check visibility before saving updates for in memory reconciliation
WT-5489       page-read can race with threads locking in-memory page structures
WT-5491       Add an option to wt verify to confirm that no data exists after the stable timestamp
WT-5493       Re-enabling test_bug008
WT-5495       WT-5495 For column store, check the on-page value and history store even if the key is in the insert list
WT-5496       upd should be reset to NULL if all upd on the chain are not visible in txn read
WT-5500       Implement new history store format
WT-5501       Do not use default session to create a history store cursor when configuring
WT-5502       Re-add changes reverted by merge commit
WT-5503       We can only free updates inserted into history store after a full update.
WT-5508       Some of the txnids not cleared after restart
WT-5509       Infinite loop when reading from history store at early specific timestamp in test_util01
WT-5510       Fix test_hs01.py, test_hs06.py (test_hs_prepare_reads)
WT-5513       Don't consider TOMBSTONE/Stop time pair for history store reads
WT-5515       Enable test_hs06
WT-5516       Backup starts with base_write_gen 1
WT-5518       Split-parent code can race with other threads when checking the WT_REF.state
WT-5519       Apply version from datastore after finding a modify when possible.
WT-5522       Remove update free logic in hs_insert_updates.
WT-5523       Inserting history store needs to handle modify based on a tombstone
WT-5525       Free up 3B in the WT_REF structure
WT-5529       Improve usage of upd in txn.i
WT-5540       Call cursor disable bulk insert on first insert to history store.
WT-5541       Use snapshot isolation whenever we use history store cursors in verification
WT-5542       History store not using the on disk value as the base value for modify when key boundary crossed
WT-5547       Disable all the skipped rollback to stable tests for column store types
WT-5549       Fix the recovery rollback to stable and enable the passing tests for both row and variable columnar types
WT-5551       Fix the history store insert statistics
WT-5552       Checkpoint reconciliation and page splits free the WT_REF.addr field without locking
WT-5555       Update base write gen to the maximum write gen we have seen in recover
WT-5556       Verify of a file should verify its history store content too
WT-5558       Use durable timestamp from the update instead of start
WT-5563       Transactions ID are getting wiped which causes errors in WT Verify
WT-5565       Core dump is generated  when running test_random_abort or test_random_direcio run on durable history branch
WT-5566       Update rollback to stable tests to use new statistics
WT-5567       Fix an assert in txn_read always be true
WT-5569       Update WiredTiger source code to include 2020 copyright notices for durable history
WT-5570       Refactor the __upd_alloc_tombstone() according to the new use in durable history
WT-5574       Rolling back a prepared transaction with `cursor_copy` results in a use-after-free
WT-5575       Fix the test_durable_ts01 test to expect older data after recovery
WT-5576       Temporarily add lookaside score stat and cache_overflow config option
WT-5579       Fix Evergreen memory sanitizer test failure
WT-5581       Address sanitizer test failure running bloom filter testing
WT-5582       Long unit testing sweeping cursors failing
WT-5583       Applying operations in recovery encounters unexpected operation type
WT-5587       Limit how many checkpoints are dropped by a subsequent checkpoint
WT-5589       force_stop on duplicate cursor open not returning error
WT-5590       Fix spellings so s_string passes
WT-5593       test/format assertion failure addr->size != 0
WT-5595       test/format data mismatch errors
WT-5596       Increase format stress testing scope.
WT-5597       Fix the history store file access during recovery
WT-5598       __verify_timestamp_to_pretty_string uses local buffer which is freed before access
WT-5602       Rollback transaction core dumped with  upd->start_ts >= unpack->stop_ts
WT-5603       test/format assertion failure while discarding in-memory page
WT-5605       Update test checkpoint to no longer use checkpoint cursors
WT-5607       Successful 'verify -h' calls are returning not found
WT-5610       Fix assertion for reconciling fixed length column store
WT-5611       Don't write updates with different commit and durable timestamps to data store
WT-5612       Remove history store values for non-timestamp tables
WT-5613       Remove birthmark update type
WT-5615       Coverity: Read of uninitialised value
WT-5618       Skip timestamp range overlap check if start timestamp is zero
WT-5620       Skip the history store TOMBSTONE only for rollback to stable operation
WT-5624       Incremental unit test should use offset/length ranges
WT-5625       corruption detected during validation - root page's aggregated timestamp incorrect
WT-5626       Remove assert which checks for newer updates in the history store
WT-5628       rollback_to_stable failed with no such file
WT-5631       Recovery rollback to stable for timestamped logged tables
WT-5632       Don't write stop_ts of 1 for non-timestamped delete
WT-5633       Fix another assertion for reconciling fixed length column store
WT-5636       prefix compression is slow in the history-store access pattern
WT-5638       Ignore checking visibility of history store updates as they are implicitly committed
WT-5640       test_wt2323_join_visibility fail when processing consecutive tombstones in __wt_hs_insert_updates
WT-5641       Clear history store content when deleting a key due to a globally visible tombstone
WT-5644       Appending onpage value to an aborted update triggers an assert
WT-5647       replace the WT_REF structure's WT_REF_READING state with a flag
WT-5648       Add a leaf or internal page type flag to the WT_REF structure
WT-5649       Refactor WT_REF locking, review all WT_REF.addr reads for locking issues
WT-5650       Fix a race condition between reading the WT_PAGE.modify field and the page being dirtied.
WT-5651       Fix the RTS assert to consider error scenarios of search
WT-5654       Add version information to the history store key format
WT-5658       Fix heap-use-after-free in parent split code
WT-5665       Data mismatch bug when running new version of test_checkpoint with timestamps
WT-5666       Deleting a chunk of the namespace changes the WT_REF type
WT-5667       Remove usage of checkpoint cursor in test/format
WT-5668       Prepare support with durable history: implement data format changes
WT-5678       Fix infinite looping behaviour in history store cursor positioning
WT-5680       segfault when dereferencing NULL addr while reconciling
WT-5682       Ensure that we can't apply modifies on top of tombstones
WT-5684       overflow values must be discarded when there is no update for a key
WT-5685       Set aspell dictionary to en_US
WT-5688       Memory leak detected during page overflow read
WT-5689       reduce work required for the cursor-pinned test.
WT-5690       Rollback to stable assertion failure regarding update visibility
WT-5692       Revert a test change to fix a Python hang
WT-5695       Fixed incremental backup example to use O_CREAT in the backup range case
WT-5696       test_timestamp_abort fails with data mismatch
WT-5698       Disabling bulk cursor changes broke a Jenkins compile
WT-5699       Refactor incremental backup RANGE code
WT-5700       Add smoke test script for incremental backup stress test
WT-5701       If an out-of-order update masks an on-disk value, don't append it
WT-5704       Incremental backup smoke test core dumped
WT-5706       Fix csuite-incr-backup-test calculation of value sizes
WT-5707       Reduce the test load for checkpoint stress test
WT-5712       Ensure WT command line utility treats history store consistently
WT-5713       Fix failures so test_durable_rollback_stable.py can be enabled
WT-5719       Incremental backup metadata should quote the ID string
WT-5722       Incremental backup should do a name check on identifiers
WT-5745       Don't copy a value into tombstones
WT-5747       Cope with updates out of timestamp order
WT-5753       Fix divide by zero error in test/csuite/test_incr_backup
WT-5756       heap-use-after-free in __wt_row_modify
WT-5762       Make test_hs10 more robust
WT-5767       Fix search_near invocations for history store
WT-5771       make-check-msan-test failed with use-of-uninitialized-value error on RHEL 8.0
WT-5774       Move stress test tasks into a separate build variant
WT-5775       Fix leak of updates from history store
WT-5777       Add statistic for tracking history store deletions due to key removal
WT-5780       Fix timestamp_index_build.js in noPassthrough suite.
WT-5781       Fix basic.js in parallel suite
WT-5786       Detect if a file is too small to read a descriptor block
WT-5792       Dump and verify can't see the history store
WT-5795       Disable assertion that inserts to the history store are unique
WT-5798       Check that the history store file exists before performing rollback to stable
WT-5799       Dont assume we have ordered timestamps when doing rec append original value
WT-5800       Temporarily disable history store verify
WT-5806       Perform rollback to stable on a clean shutdown
WT-5809       Invariant failure: stable timestamp does not equal appliedThrough timestamp
WT-5820       Change format.sh to forcibly quit if a test runs out of disk space.
WT-5822       Don't evict metadata updates from a running checkpoint
WT-5827       Enable test_schema_abort
WT-5830       Enable two c tests in evergreen
  • Loading branch information
lukech authored and Evergreen Agent committed Mar 15, 2020
1 parent 8f6fa99 commit 00502b1
Show file tree
Hide file tree
Showing 225 changed files with 14,066 additions and 7,738 deletions.
2 changes: 1 addition & 1 deletion src/third_party/wiredtiger/NEWS
Expand Up @@ -2460,7 +2460,7 @@ below:
now it will be used if the shared_cache configuration option is included.

* Add the ability to specify a per-connection reserved size for cache
pools. Ensure cache pool reconfiguration is honoured quickly.
pools. Ensure cache pool reconfiguration is honored quickly.

* Rework hazard pointer coupling during cursor walks to be more efficient.

Expand Down
3 changes: 2 additions & 1 deletion src/third_party/wiredtiger/SConstruct
Expand Up @@ -407,7 +407,8 @@ shim = env.Library("window_shim",

examples = [
"ex_access",
"ex_all",
# Temporarily disabled
# "ex_all",
"ex_async",
"ex_call_center",
"ex_config_parse",
Expand Down
Expand Up @@ -26,7 +26,7 @@
# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
# OTHER DEALINGS IN THE SOFTWARE.

# This benchmark is designed to stress disk access to the LAS/History Store file.
# This benchmark is designed to stress disk access to the history store file.
# This is achieved through:
# - Long running transactions consisting of read and update operations.
# - Low cache size (~20%) for a reasonably sized WT table with large documents.
Expand Down
14 changes: 0 additions & 14 deletions src/third_party/wiredtiger/build_posix/aclocal/options.m4
Expand Up @@ -185,20 +185,6 @@ pthread_adaptive|pthreads_adaptive)
esac
AC_MSG_RESULT($with_spinlock)
AH_TEMPLATE(HAVE_PAGE_VERSION_TS,
[Define to 1 to enable writing timestamp version page formats.])
AC_MSG_CHECKING(if --enable-page-version-ts option specified)
AC_ARG_ENABLE(page-version-ts,
[AS_HELP_STRING([--enable-page-version-ts],
[Configure for timestamp version page formats])],
r=$enableval, r=no)
case "$r" in
no) wt_cv_enable_page_version_ts=no;;
*) AC_DEFINE(HAVE_PAGE_VERSION_TS)
wt_cv_enable_page_version_ts=yes;;
esac
AC_MSG_RESULT($wt_cv_enable_page_version_ts)
AC_MSG_CHECKING(if --enable-strict option specified)
AC_ARG_ENABLE(strict,
[AS_HELP_STRING([--enable-strict],
Expand Down
3 changes: 0 additions & 3 deletions src/third_party/wiredtiger/build_win/wiredtiger_config.h
Expand Up @@ -73,9 +73,6 @@
/* Define to 1 to disable any crc32 hardware support. */
/* #undef HAVE_NO_CRC32_HARDWARE */

/* Define to 1 to enable writing timestamp version page formats. */
/* #undef HAVE_PAGE_VERSION_TS */

/* Define to 1 if pthread condition variables support monotonic clocks. */
/* #undef HAVE_PTHREAD_COND_MONOTONIC */

Expand Down
68 changes: 35 additions & 33 deletions src/third_party/wiredtiger/dist/api_data.py
Expand Up @@ -461,7 +461,19 @@ def __ge__(self, other):
this size, a panic will be triggered. The default value means that
the cache overflow file is unbounded and may use as much space as
the filesystem will accommodate. The minimum non-zero setting is
100MB.''', # !!! Must match WT_LAS_FILE_MIN
100MB.''', # !!! TODO: WT-5585 To be removed when we switch to history_store config
min='0')
]),
Config('history_store', '', r'''
history store configuration options''',
type='category', subconfig=[
Config('file_max', '0', r'''
The maximum number of bytes that WiredTiger is allowed to use for
its history store mechanism. If the history store file exceeds
this size, a panic will be triggered. The default value means that
the history store file is unbounded and may use as much space as
the filesystem will accommodate. The minimum non-zero setting is
100MB.''', # !!! Must match WT_HS_FILE_MIN
min='0')
]),
Config('cache_overhead', '8', r'''
Expand Down Expand Up @@ -506,7 +518,7 @@ def __ge__(self, other):
type='boolean'),
Config('eviction', 'false', r'''
if true, modify internal algorithms to change skew to force
lookaside eviction to happen more aggressively. This includes but
history store eviction to happen more aggressively. This includes but
is not limited to not skewing newest, not favoring leaf pages,
and modifying the eviction score mechanism.''',
type='boolean'),
Expand Down Expand Up @@ -687,7 +699,7 @@ def __ge__(self, other):
intended for use with internal stress testing of WiredTiger.''',
type='list', undoc=True,
choices=[
'aggressive_sweep', 'checkpoint_slow', 'lookaside_sweep_race',
'aggressive_sweep', 'checkpoint_slow', 'history_store_sweep_race',
'split_1', 'split_2', 'split_3', 'split_4', 'split_5', 'split_6',
'split_7', 'split_8']),
Config('verbose', '', r'''
Expand All @@ -698,6 +710,7 @@ def __ge__(self, other):
'backup',
'block',
'checkpoint',
'checkpoint_gc',
'checkpoint_progress',
'compact',
'compact_progress',
Expand All @@ -708,8 +721,8 @@ def __ge__(self, other):
'fileops',
'handleops',
'log',
'lookaside',
'lookaside_activity',
'history_store',
'history_store_activity',
'lsm',
'lsm_manager',
'metadata',
Expand All @@ -720,6 +733,7 @@ def __ge__(self, other):
'reconcile',
'recovery',
'recovery_progress',
'rts',
'salvage',
'shared_cache',
'split',
Expand Down Expand Up @@ -1346,13 +1360,19 @@ def __ge__(self, other):
'WT_SESSION.upgrade' : Method([]),
'WT_SESSION.verify' : Method([
Config('dump_address', 'false', r'''
Display addresses and page types as pages are verified,
using the application's message handler, intended for debugging''',
Display page addresses, start and stop time pairs and page types as
pages are verified, using the application's message handler,
intended for debugging''',
type='boolean'),
Config('dump_blocks', 'false', r'''
Display the contents of on-disk blocks as they are verified,
using the application's message handler, intended for debugging''',
type='boolean'),
Config('dump_history', 'false', r'''
Display a key's values along with its start and stop time pairs as
they are verified against the history store, using the application's
message handler, intended for debugging''',
type='boolean'),
Config('dump_layout', 'false', r'''
Display the layout of the files as they are verified, using the
application's message handler, intended for debugging; requires
Expand All @@ -1366,11 +1386,18 @@ def __ge__(self, other):
Display the contents of in-memory pages as they are verified,
using the application's message handler, intended for debugging''',
type='boolean'),
Config('history_store', 'false', r'''
Verify the history store.''',
type='boolean'),
Config('stable_timestamp', 'false', r'''
Ensure that no data has a start timestamp after the stable timestamp,
to be run after rollback_to_stable.''',
type='boolean'),
Config('strict', 'false', r'''
Treat any verification problem as an error; by default, verify will
warn, but not fail, in the case of errors that won't affect future
behavior (for example, a leaked block)''',
type='boolean')
type='boolean'),
]),

'WT_SESSION.begin_transaction' : Method([
Expand Down Expand Up @@ -1421,9 +1448,6 @@ def __ge__(self, other):
read timestamp will be rounded up to the oldest timestamp''',
type='boolean'),
]),
Config('snapshot', '', r'''
use a named, in-memory snapshot, see
@ref transaction_named_snapshots'''),
Config('sync', '', r'''
whether to sync log records when the transaction commits,
inherited from ::wiredtiger_open \c transaction_sync''',
Expand Down Expand Up @@ -1513,28 +1537,6 @@ def __ge__(self, other):
type='boolean'),
]),

'WT_SESSION.snapshot' : Method([
Config('drop', '', r'''
if non-empty, specifies which snapshots to drop. Where a group
of snapshots are being dropped, the order is based on snapshot
creation order not alphanumeric name order''',
type='category', subconfig=[
Config('all', 'false', r'''
drop all named snapshots''', type='boolean'),
Config('before', '', r'''
drop all snapshots up to but not including the specified name'''),
Config('names', '', r'''
drop specific named snapshots''', type='list'),
Config('to', '', r'''
drop all snapshots up to and including the specified name'''),
]),
Config('include_updates', 'false', r'''
make updates from the current transaction visible to users of the
named snapshot. Transactions started with such a named snapshot are
restricted to being read-only''', type='boolean'),
Config('name', '', r'''specify a name for the snapshot'''),
]),

'WT_CONNECTION.add_collator' : Method([]),
'WT_CONNECTION.add_compressor' : Method([]),
'WT_CONNECTION.add_data_source' : Method([]),
Expand Down
3 changes: 1 addition & 2 deletions src/third_party/wiredtiger/dist/filelist
Expand Up @@ -49,7 +49,6 @@ src/btree/col_srch.c
src/btree/row_key.c
src/btree/row_modify.c
src/btree/row_srch.c
src/cache/cache_las.c
src/checksum/arm64/crc32-arm64.c ARM64_HOST
src/checksum/power8/crc32.sx POWERPC_HOST
src/checksum/power8/crc32_wrapper.c POWERPC_HOST
Expand Down Expand Up @@ -98,6 +97,7 @@ src/evict/evict_file.c
src/evict/evict_lru.c
src/evict/evict_page.c
src/evict/evict_stat.c
src/history/hs.c
src/log/log.c
src/log/log_auto.c
src/log/log_slot.c
Expand Down Expand Up @@ -209,7 +209,6 @@ src/txn/txn.c
src/txn/txn_ckpt.c
src/txn/txn_ext.c
src/txn/txn_log.c
src/txn/txn_nsnap.c
src/txn/txn_recover.c
src/txn/txn_rollback_to_stable.c
src/txn/txn_timestamp.c
48 changes: 21 additions & 27 deletions src/third_party/wiredtiger/dist/s_clang-scan.diff
@@ -1,33 +1,27 @@
In file included from src/block/block_write.c:9:
In file included from ./src/include/wt_internal.h:412:
./src/include/intpack.i:194:4: warning: Assigned value is garbage or undefined
p = *pp;
^ ~~~
In file included from ./src/include/wt_internal.h:418:
./src/include/intpack.i:193:7: warning: Assigned value is garbage or undefined
p = *pp;
^ ~~~
1 warning generated.
src/conn/conn_capacity.c:310:2: warning: Value stored to 'capacity' is never read
capacity = steal_capacity = 0;
^ ~~~~~~~~~~~~~~~~~~
In file included from src/btree/col_modify.c:9:
In file included from ./src/include/wt_internal.h:423:
./src/include/mutex.i:158:13: warning: Null pointer passed as an argument to a 'nonnull' parameter
return (pthread_mutex_trylock(&t->lock));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/conn/conn_capacity.c:291:5: warning: Value stored to 'capacity' is never read
capacity = steal_capacity = 0;
^ ~~~~~~~~~~~~~~~~~~
1 warning generated.
src/reconcile/rec_col.c:1079:25: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcmp(last.value->data, data, size) == 0))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/reconcile/rec_col.c:700:2: warning: Value stored to 'start_ts' is never read
start_ts = WT_TS_MAX;
^ ~~~~~~~~~
src/reconcile/rec_col.c:701:2: warning: Value stored to 'start_txn' is never read
start_txn = WT_TXN_MAX;
^ ~~~~~~~~~~
src/reconcile/rec_col.c:702:2: warning: Value stored to 'stop_ts' is never read
stop_ts = WT_TS_NONE;
^ ~~~~~~~~~~
src/reconcile/rec_col.c:703:2: warning: Value stored to 'stop_txn' is never read
stop_txn = WT_TS_NONE;
^ ~~~~~~~~~~
src/reconcile/rec_col.c:1199:9: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcmp(
^~~~~~~
5 warnings generated.
In file included from src/reconcile/rec_write.c:9:
In file included from ./src/include/wt_internal.h:417:
./src/include/mutex.i:187:13: warning: Null pointer passed as an argument to a 'nonnull' parameter
if ((ret = pthread_mutex_unlock(&t->lock)) != 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./src/include/wt_internal.h:423:
./src/include/mutex.i:184:16: warning: Null pointer passed as an argument to a 'nonnull' parameter
if ((ret = pthread_mutex_unlock(&t->lock)) != 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
ar: `u' modifier ignored since `D' is the default (see `U')
3 changes: 2 additions & 1 deletion src/third_party/wiredtiger/dist/s_define.list
Expand Up @@ -35,6 +35,7 @@ WT_ERR_ERROR_OK
WT_EXT_FOREACH_OFF
WT_HANDLE_CLOSED
WT_HANDLE_NULLABLE
WT_HS_COMPRESSOR
WT_LOG_SLOT_ACTIVE
WT_LOG_SLOT_BITS
WT_LOG_SLOT_JOIN_MASK
Expand All @@ -44,7 +45,6 @@ WT_LOG_SLOT_MAXBITS
WT_LOG_SLOT_UNBUFFERED_ISSET
WT_LOG_V3_MAJOR
WT_LOG_V3_MINOR
WT_LOOKASIDE_COMPRESSOR
WT_OPTRACK_BUFSIZE
WT_OPTRACK_MAXRECS
WT_PACKED_STRUCT_BEGIN
Expand Down Expand Up @@ -82,6 +82,7 @@ WT_TRACK_OP
WT_TRACK_OP_END
WT_TRACK_OP_INIT
WT_TRET_ERROR_OK
WT_TXN_UPDATE
WT_UPDATE_SIZE
WT_USE_OPENAT
WT_WITH_LOCK_NOWAIT
Expand Down
2 changes: 1 addition & 1 deletion src/third_party/wiredtiger/dist/s_funcs.list
Expand Up @@ -16,8 +16,8 @@ __wt_config_getone
__wt_cursor_get_raw_value
__wt_debug_addr
__wt_debug_addr_print
__wt_debug_cursor_las
__wt_debug_cursor_page
__wt_debug_cursor_tree_hs
__wt_debug_offset
__wt_debug_set_verbose
__wt_debug_tree
Expand Down
4 changes: 2 additions & 2 deletions src/third_party/wiredtiger/dist/s_string
Expand Up @@ -22,7 +22,7 @@ type aspell > /dev/null 2>&1 || {
# catalogs and generating a shorter list on any single system will break other
# systems.
replace() {
aspell --mode=ccpp --lang=en list < ../$1 |
aspell --mode=ccpp --lang=en_US list < ../$1 |
sort -u |
comm -12 /dev/stdin s_string.ok
}
Expand All @@ -33,7 +33,7 @@ check() {
# Strip out git hashes, which are seven character hex strings.
# Strip out double quote char literals ('"'), they confuse aspell.
sed -e 's/ [0-9a-f]\{7\} / /g' -e "s/'\"'//g" ../$2 |
aspell --lang=en $1 list |
aspell --lang=en_US $1 list |
sort -u |
comm -23 /dev/stdin s_string.ok > $t
test -s $t && {
Expand Down

0 comments on commit 00502b1

Please sign in to comment.