SERVER-31091 Make Balancer::joinCurrentRound obey the OperationContex…

…t deadline (cherry picked from commit 689e308)
mongodb · Oct 18, 2017 · 078f289 · 078f289
1 parent 998863e
commit 078f289
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/mongo/db/s/balancer/balancer.cpp b/src/mongo/db/s/balancer/balancer.cpp
@@ -243,8 +243,9 @@ void Balancer::waitForBalancerToStop() {
 void Balancer::joinCurrentRound(OperationContext* opCtx) {
     stdx::unique_lock<stdx::mutex> scopedLock(_mutex);
     const auto numRoundsAtStart = _numBalancerRounds;
-    _condVar.wait(scopedLock,
-                  [&] { return !_inBalancerRound || _numBalancerRounds != numRoundsAtStart; });
+    opCtx->waitForConditionOrInterrupt(_condVar, scopedLock, [&] {
+        return !_inBalancerRound || _numBalancerRounds != numRoundsAtStart;
+    });
 }
 
 Status Balancer::rebalanceSingleChunk(OperationContext* opCtx, const ChunkType& chunk) {

diff --git a/src/mongo/db/s/balancer/balancer.h b/src/mongo/db/s/balancer/balancer.h
@@ -110,7 +110,8 @@ class Balancer {
 
     /**
      * Potentially blocking method, which will return immediately if the balancer is not running a
-     * balancer round and will block until the current round completes otherwise.
+     * balancer round and will block until the current round completes otherwise. If the operation
+     * context's deadline is exceeded, it will throw an ExceededTimeLimit exception.
      */
     void joinCurrentRound(OperationContext* txn);