SERVER-21388 validate captrunc argument

mongodb · Jan 28, 2016 · f2a6770 · f2a6770
1 parent a2ad8f9
commit f2a6770
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/jstests/noPassthroughWithMongod/capped_truncate.js b/jstests/noPassthroughWithMongod/capped_truncate.js
@@ -11,6 +11,13 @@
                                          autoIndexId: true }));
     var t = db.capped_truncate;
 
+    // It is an error to remove a non-positive number of documents.
+    assert.commandFailed(db.runCommand({ captrunc: "capped_truncate", n: -1 }),
+                         "captrunc didn't return an error when attempting to remove a negative " +
+                         "number of documents");
+    assert.commandFailed(db.runCommand({ captrunc: "capped_truncate", n: 0 }),
+                         "captrunc didn't return an error when attempting to remove 0 documents");
+
     for (var j = 1; j <= 10; j++) {
         assert.writeOK(t.insert({x:j}));
     }

diff --git a/src/mongo/db/commands/test_commands.cpp b/src/mongo/db/commands/test_commands.cpp
@@ -189,7 +189,13 @@ class CapTrunc : public Command {
         int n = cmdObj.getIntField("n");
         bool inc = cmdObj.getBoolField("inc");  // inclusive range?
 
+        if (n <= 0) {
+            return appendCommandStatus(result,
+                                       {ErrorCodes::BadValue, "n must be a positive integer"});
+        }
+
         Client::WriteContext ctx(txn, nss.ns());
+
         Collection* collection = ctx.getCollection();
         massert(13417, "captrunc collection not found or empty", collection);