SERVER-2009 don't skip location on yield recovery when the location h…

…as already been updated
mongodb · Jun 2, 2011 · f2beea1 · f2beea1
1 parent 70fbe10
commit f2beea1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/db/clientcursor.cpp b/db/clientcursor.cpp
@@ -231,10 +231,13 @@ namespace mongo {
             c->checkLocation();
             DiskLoc tmp1 = c->refLoc();
             if ( tmp1 != dl ) {
-                /* this might indicate a failure to call ClientCursor::updateLocation() */
+                // This might indicate a failure to call ClientCursor::updateLocation() but it can
+                // also happen during correct operation, see SERVER-2009.
                 problem() << "warning: cursor loc " << tmp1 << " does not match byLoc position " << dl << " !" << endl;
             }
-            c->advance();
+            else {
+                c->advance();
+            }
             if ( c->eof() ) {
                 // advanced to end
                 // leave ClientCursor in place so next getMore doesn't fail

diff --git a/jstests/remove9.js b/jstests/remove9.js
@@ -1,6 +1,5 @@
 // SERVER-2009 Count odd numbered entries while updating and deleting even numbered entries.
 
-if ( 0 ) { // SERVER-2009
 t = db.jstests_remove9;
 t.drop();
 t.ensureIndex( {i:1} );
@@ -15,4 +14,3 @@ for( i = 0; i < 1000; ++i ) {
 }
 
 s();
-}