Make findAndModify helper function return null rather than {} (no cha…

…nge to server API)
mongodb · Jul 2, 2010 · fe54b5d · fe54b5d
1 parent 224ca4a
commit fe54b5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jstests/find_and_modify.js b/jstests/find_and_modify.js
@@ -33,6 +33,6 @@ assert.eq(out.priority, 1);
 out = t.findAndModify({sort:{priority:1}, remove:1});
 assert.eq(out.priority, 2);
 
-// return empty obj if no matches (drivers may handle this differently)
+// return null (was {} before 1.5.4) if no matches (drivers may handle this differently)
 out = t.findAndModify({query:{no_such_field:1}, remove:1});
-assert.eq(out, {});
+assert.eq(out, null);
diff --git a/shell/collection.js b/shell/collection.js
@@ -337,7 +337,7 @@ DBCollection.prototype.findAndModify = function(args){
     var ret = this._db.runCommand( cmd );
     if ( ! ret.ok ){
         if (ret.errmsg == "No matching object found"){
-            return {};
+            return null;
         }
         throw "findAndModifyFailed failed: " + tojson( ret.errmsg );
     }