update distsrc/client/SConstruct #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for CXX related environment variables and set corresponding Scons Construction Variables LDPATH is set before boost lib check to avoid incorrect fail condition
ghost
assigned 
|
Rather than adopting the values from the environment variables, they should be take from command line options. It is intentional that SCons and our SConstruct files avoid implicit parameter setting from the environment. Say --cxx, --cc and --ldpath? --ldpath could be repeatable, much as the -L parameter to the linker is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check for CXX related environment variables and set corresponding Scons Construction Variables
LDPATH is set before boost lib check to avoid incorrect fail condition