SERVER-7485 Allow ranges in the delay argument in mongobridge #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each query passing through will be delayed by a random value between the start and end delay value.
milkie
pushed a commit
that referenced
this pull request
Apr 8, 2013
This should be compatible with future improvements to support ranged delays (see #317) Support unidirectional network partitioning in ReplSetTest The default behavior (bidirectional) remains as-is. This adds support for terminating an X->Y link while leaving Y->X untouched. Test replica set flapping and heartbeatTimeoutSecs Also adds two fail points to support JS tests. rsDelayHeartbeatResponse will delay the replSetHeartbeat command response on a node. rsStopHeartbeatRequest may be used to preemptively fail a heartbeat to another member (by its host:port). Signed-off-by: Eric Milkie <milkie@10gen.com>
|
@derickr - any plans to revisit this pull request and address Tad's feedback? If not, I'd like to close this pull request since it's 9 months old. |
|
I'd still like to do it - just not very high on my to-do list anymore. |
|
Mind if I leave the SERVER ticket open and assigned to you, but close this pull request? Feel free to reopen when you have something for us to review. |
|
Go for it |
BradBarnich
pushed a commit
to BradBarnich/mongo
that referenced
this pull request
Feb 6, 2019
merge 3.6.0-rc2 & rc3 into PSMDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each query passing through will be delayed by a random value between
the start and end delay value. This extends the functionality that was added
in #257 and extends --delay 30
to --delay 10-40.