Fix for disk size growth in high insert / delete environment #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: client/dbclient_rs.cpp
Conflicts: s/d_migrate.cpp
Conflicts: db/dur_commitjob.cpp
… on the output collection
…nection, not replica set connection SERVER-3683 Conflicts: s/shard_version.cpp
…es array in the replica set monitor. SERVER-3605
…are in flight. also correct UpdateResult in one case Conflicts: db/oplog.cpp db/repl/rs_sync.cpp
Conflicts: db/repl/rs_sync.cpp
Conflicts: db/repl/rs_sync.cpp
…f retrying indefinitely. SERVER-4196
Conflicts: db/repl.cpp db/repl.h db/repl/rs_sync.cpp
Conflicts: dbtests/repltests.cpp
|
It seems this was merged into 1.8.5. The above description indicates, "new command line option" to control this behavior but in the code diff I do not see a command line change related to this. Is there a command line flag? Is there any reason not to always do the new approach and avoid deletes not freeing space? |
puppyofkosh
added a commit
that referenced
this pull request
Feb 12, 2019
…f invocation) Original commit message from timelib: Fixed #37: Incorrect snprintf invocation with static buffer
puppyofkosh
added a commit
that referenced
this pull request
Feb 12, 2019
…f invocation) Original commit message from timelib: Fixed #37: Incorrect snprintf invocation with static buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I work on a high insert / delete application the issue with mongodb disk space has become a large problem. I did some testing on v1.8 of the following changes that adds a new command line option to allocate to the next closest bucket size used by the freelist. In my testing, this has eliminated the disk growth in a high insert / delete environment. The test program I wrote basically executes the following algorithm:
With the patched version the number of extents and allocated space stayed constant and the non-patched server grows from 368,078,848 to 1 GB.