Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER-9191 fix oplog page for dbs that require admin login #412

Closed
wants to merge 1 commit into from

Conversation

cxmcc
Copy link
Contributor

@cxmcc cxmcc commented Apr 5, 2013

In oplog page on rest interface, use oplogreader (which had authentication) instead of dbclient (w/o auth) to query oplogs. This fixes the broken oplog page for dbs having a admin account.

https://jira.mongodb.org/browse/SERVER-9191

@cxmcc
Copy link
Contributor Author

cxmcc commented Apr 12, 2013

CA signed.

@ghost ghost assigned milkie May 8, 2013
@kangas
Copy link
Contributor

kangas commented May 8, 2013

Hi Xiuming,

I see that you have submitted a contributor agreement on 2013-04-05, but your GitHub username was blank. Can you please resubmit the form at http://www.10gen.com/legal/contributor-agreement ? This will help us verify compliance quickly in the future.

I see that Eric Milkie has discussed this issue with you. I will follow up with him to see what the current status is.

@cxmcc
Copy link
Contributor Author

cxmcc commented May 8, 2013

Hi @kangas , I signed that again few moments ago. Please let me know if it still has issues. Thanks.

@kangas
Copy link
Contributor

kangas commented May 9, 2013

@cxmcc I see your updated contributors agreement, it looks good. Thanks!

@kangas
Copy link
Contributor

kangas commented May 31, 2013

@xmcc Can you make the changes that Eric suggested? I think these are the only obstacles we are aware of to getting your change included.

…id authentication) instead of dbclient (w/o auth) to query oplogs. This fixes the broken oplog page for dbs having a admin account.
@cxmcc
Copy link
Contributor Author

cxmcc commented May 31, 2013

hi @milkie @kangas sorry for the delay
I did modifications (amended in commit) based on the review:

  • rename variable "r" to "reader" (Please let me know if this is better, or if you have a better name in mind?)
  • keep lines to 100 characters or less

Thanks

@ghost ghost assigned dannenberg Jun 5, 2013
@kangas
Copy link
Contributor

kangas commented Jun 26, 2013

Merged in 23f8257. Thank you for contributing to MongoDB, Xiuming!

@kangas kangas closed this Jun 26, 2013
@cxmcc cxmcc deleted the SERVER-9191 branch June 27, 2013 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants