SERVER-9923 mongod blocks writes to all databases if filesystem hosting one database is full #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zhihuiFan, I see that you signed our contributor agreement, and your pull request references a SERVER ticket. Thank you for reading CONTRIBUTING.rst. :) I will assign someone to review this as soon as possible. |
|
Thank you Kangas :) |
benety
changed the title
|
@zhihuiFan looks like the PR needs to be rebased in order to be mergable |
|
@benmccann, thanks for bringing this to our attention. @kaloianm's change in 7257da6 for SERVER-14243 pretty much invalidates this pull request. @zhihuiFan, thank you for your submission. Unfortunately, we will have to close this pull request. Please feel free to continue the discussion in SERVER-9923. |
jiongle1
pushed a commit
to scantist-ossops-m2/mongo
that referenced
this pull request
Mar 30, 2024
it was never implemented. Reference mongodb#616.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is changing FileAllocator::_failed from bool to map<string db, bool>.
besides that, I also changed FileAllocator::run to release lock before sleep 10 seconds in exception case. and also move the failed file name to the pending last. Please let me know there is any issue for this change. thanks!