Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SERVER-15700 Modify SortedDataInterface to not require unindex() to return whether the index row was deleted #827

Closed
wants to merge 1 commit into from
Closed

SERVER-15700 Modify SortedDataInterface to not require unindex() to return whether the index row was deleted #827

wants to merge 1 commit into from

Conversation

esmet
Copy link
Contributor

@esmet esmet commented Oct 17, 2014

Discussion: https://groups.google.com/forum/#!topic/mongodb-dev/75ZSCUrgmtk
Jira: https://jira.mongodb.org/browse/SERVER-15700

  • SortedDataInterface::unindex() modified to return void, no longer checks for existence of target index key
  • Storage engine unit tests were modified and cleanly pass
  • Development environment: Ubuntu 13.10 with gcc-4.8.1

@esmet
SERVER-15700 Modify SortedDataInterface to not require unindex() to r…
409031a 
…eturn

whether the index row was deleted. Fix unit tests to manually verify that
unindex() operations had the desired effect (in the same operation context)
@benety
Copy link
Contributor

benety commented Oct 17, 2014

https://jira.mongodb.org/browse/SERVER-15700

@benety benety closed this in a1b5c09 Oct 17, 2014
@benety
Copy link
Contributor

benety commented Oct 17, 2014

Hi @esmet,

This has been merged in a1b5c09.

Thank you for contributing to MongoDB!
Ben

@benety benety mentioned this pull request Oct 17, 2014
Closed
@esmet esmet deleted the unindex branch October 17, 2014 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@esmet @benety