CLOUDP-79093: [mongocli] move to github actions (#548)

.github/workflows/pr.yml

@@ -0,0 +1,38 @@
+---
+name: CI
+on: [push, pull_request]
+jobs:
+  golangci-lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: lint
+        uses: golangci/golangci-lint-action@v2.3.0
+        with:
+          version: v1.33.0
+
+  tests:
+    needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
+    strategy:
+      fail-fast: false
+      matrix:
+        golang: [1.15]
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+      - name: Install Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.golang }}
+      - name: Cache Dependencies
+        uses: actions/cache@v2
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ matrix.golang }}-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-${{ matrix.golang }}-
+      - name: Run tests
+        run: make test

.github/workflows/security.yml

@@ -0,0 +1,15 @@
+---
+name: Snyk
+on:
+  push:
+    branches:
+      - master
+jobs:
+  security:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run Snyk to check for vulnerabilities
+        uses: snyk/actions/golang@master
+        env:
+          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}

Makefile

@@ -83,7 +83,7 @@ e2e-test: build ## Run E2E tests
 .PHONY: integration-test
 integration-test: ## Run integration tests
 	@echo "==> Running integration tests..."
-	${TEST_CMD} --tags="${INTEGRATION_TAGS}" ./internal...
+	${TEST_CMD} --tags="${INTEGRATION_TAGS}" -count=1 ./internal...
 
 .PHONY: unit-test
 unit-test: ## Run unit-tests

README.md

@@ -3,7 +3,7 @@
 </p>
 
 
-[![Build Status](https://cloud.drone.io/api/badges/mongodb/mongocli/status.svg)](https://cloud.drone.io/mongodb/mongocli)
+![CI](https://github.com/mongodb/mongocli/workflows/CI/badge.svg)
 
 `mongocli` is a tool for managing your MongoDB cloud services
 

internal/config/profile.go

@@ -16,8 +16,8 @@ package config
 
 import (
 	"errors"
-	"fmt"
 	"log"
+	"path/filepath"
 	"sort"
 	"strings"
 
@@ -313,7 +313,7 @@ func (p *Profile) Delete() error {
 }
 
 func (p *Profile) Filename() string {
-	return fmt.Sprintf("%s/%s.toml", p.configDir, ToolName)
+	return filepath.Join(p.configDir, ToolName+".toml")
 }
 
 // Rename replaces the Profile to a new Profile name, overwriting any Profile that existed before.
@@ -392,6 +392,6 @@ func (p *Profile) Save() error {
 			return err
 		}
 	}
-	configFile := fmt.Sprintf("%s/%s.toml", p.configDir, ToolName)
+	configFile := p.Filename()
 	return viper.WriteConfigAs(configFile)
 }

internal/config/profile_integration_test.go

@@ -17,6 +17,7 @@
 package config
 
 import (
+	"path/filepath"
 	"testing"
 
 	"github.com/spf13/afero"
@@ -30,15 +31,18 @@ const (
 
 func testProfile(profileContents string) *Profile {
 	fs := afero.NewMemMapFs()
-	testConfigDir := "/test"
+	testConfigDir, _ := filepath.Abs("test")
 
 	p := &Profile{
 		name:      DefaultProfile,
 		configDir: testConfigDir,
 		fs:        fs,
 	}
 
-	_ = afero.WriteFile(fs, p.Filename(), []byte(profileContents), 0600)
+	if err := afero.WriteFile(fs, p.Filename(), []byte(profileContents), 0600); err != nil {
+		panic(err)
+	}
+
 	return p
 }