Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-172901: DB Users - Remove double query encoding #1901

Merged
merged 2 commits into from
Apr 25, 2023
Merged

CLOUDP-172901: DB Users - Remove double query encoding #1901

merged 2 commits into from
Apr 25, 2023

Conversation

matt-condon
Copy link
Collaborator

Proposed changes

Removing double query-encoding that causes db users Get to fail

Jira ticket: CLOUDP-172901

Closes #1817

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@matt-condon matt-condon requested a review from a team April 24, 2023 16:52
swattyT
swattyT approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@swattyT swattyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gssbzn
gssbzn approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@matt-condon matt-condon merged commit 7e4b074 into master Apr 25, 2023
@matt-condon matt-condon deleted the CLOUDP-172901 branch April 25, 2023 08:58
@matt-condon matt-condon mentioned this pull request Apr 25, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@wtrocki wtrocki wtrocki approved these changes

@swattyT swattyT swattyT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USERNAME_NOT_FOUND for created AWS IAM role user
4 participants
@matt-condon @gssbzn @wtrocki @swattyT