Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-69463: mongocli atlas networking peering watch #372

Merged
merged 3 commits into from
Aug 18, 2020
Merged

CLOUDP-69463: mongocli atlas networking peering watch #372

merged 3 commits into from
Aug 18, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 18, 2020

Proposed changes

Jira ticket: CLOUDP-69463

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

mongocli atlas networking peering watch 5f3c0053fecf5e715adbb5d9  -P dev
......................................................
Network peering changes completed.

andreaangiolillo
andreaangiolillo previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/cli/atlas/networking/peering/create/aws_test.go
@@ -97,8 +96,8 @@ func TestNormalizeAtlasRegion(t *testing.T) {

for _, tc := range tests {
got := normalizeAtlasRegion(tc.input)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

internal/cli/atlas/networking/peering/descriptions.go Outdated Show resolved Hide resolved
@gssbzn @andreaangiolillo
Update internal/cli/atlas/networking/peering/descriptions.go
a8b136a 
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
andreaangiolillo
andreaangiolillo approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit d8e4149 into master Aug 18, 2020
@gssbzn gssbzn deleted the CLOUDP-69463 branch August 18, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@robcarlan-mlab robcarlan-mlab Awaiting requested review from robcarlan-mlab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gssbzn @andreaangiolillo