Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-70550: Allow comma separate values for roles #386

Merged
merged 1 commit into from
Aug 28, 2020
Merged

CLOUDP-70550: Allow comma separate values for roles #386

merged 1 commit into from
Aug 28, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 28, 2020

Proposed changes

Jira ticket: CLOUDP-70550

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

StringArrayVar doesn't handle --role ROLE_1,ROLE2 only --role ROLE_1 --role ROLE_2 while StringSliceVar does

colm-quinn
colm-quinn approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gssbzn gssbzn merged commit 734e025 into master Aug 28, 2020
@gssbzn gssbzn deleted the CLOUDP-70550 branch August 28, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gssbzn @colm-quinn