CLOUDP-70015: mongocli iam org(s) user(s) list|ls #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Sep 2, 2020
| cmd.AddCommand(CreateBuilder()) | ||
| cmd.AddCommand(DeleteBuilder()) | ||
| cmd.AddCommand(apikeys.Builder()) | ||
| cmd.AddCommand( |
|
|
||
| const ( | ||
| short = "Users operations." | ||
| long = "Create, list and manage your Atlas/Cloud Manager/Ops Manager users." |
There was a problem hiding this comment.
I think we should only mention listing, I don't think we support anything else
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| const atlasUserListTemplate = `ID FIRST NAME LAST NAME EMAIL{{range .Results}} |
There was a problem hiding this comment.
for the sake of having a single template I'm ok with updating the om client to return the full object, ie including the Result field
There was a problem hiding this comment.
also could we match this to the describe command? we had username there I think, this to avoid surprises from users and offer a consistent view
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
oh sorry @gssbzn I didn't see you PR 😖 Thanks for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-70015
Checklist
make fmtand formatted my codeFurther comments
Atlas
OM