-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-70015: mongocli iam org(s) user(s) list|ls #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits, thanks for some of the fixes here and there
cmd.AddCommand(CreateBuilder()) | ||
cmd.AddCommand(DeleteBuilder()) | ||
cmd.AddCommand(apikeys.Builder()) | ||
cmd.AddCommand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
|
||
const ( | ||
short = "Users operations." | ||
long = "Create, list and manage your Atlas/Cloud Manager/Ops Manager users." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only mention listing, I don't think we support anything else
"github.com/spf13/cobra" | ||
) | ||
|
||
const atlasUserListTemplate = `ID FIRST NAME LAST NAME EMAIL{{range .Results}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the sake of having a single template I'm ok with updating the om client to return the full object, ie including the Result field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also could we match this to the describe command? we had username there I think, this to avoid surprises from users and offer a consistent view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry @gssbzn I didn't see you PR 😖 Thanks for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-70015
Checklist
make fmt
and formatted my codeFurther comments
Atlas
OM