-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-72563: Add e2e tests maintenance windows #433
Conversation
metrics.Builder(), | ||
logs.Builder(), | ||
agents.Builder(), | ||
maintenance.Builder(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the importante of testing - Vol 2 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a couple of small things here mostly look like copy/paste but in general this looks great, it's always great to add these
e2e/atlas/maintenance_test.go
Outdated
t.Fatalf("unexpected error: %v", err) | ||
} | ||
|
||
projectName := fmt.Sprintf("e2e-integration-proj-%v", n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy/paste
projectName := fmt.Sprintf("e2e-integration-proj-%v", n) | |
projectName := fmt.Sprintf("e2e-maintenance-proj-%v", n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-72563
Checklist
make fmt
and formatted my codeFurther comments