Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-70067: mongocli atlas|om|cm performanceAdvisor suggestedIndexes ls #448

Merged
merged 23 commits into from
Sep 22, 2020
Merged

CLOUDP-70067: mongocli atlas|om|cm performanceAdvisor suggestedIndexes ls #448

merged 23 commits into from
Sep 22, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 15, 2020 •
edited

Proposed changes

Jira ticket: CLOUDP-70067

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli atlas performanceAdvisor suggestedIndexes ls --processName atlas-k11skw-shard-00-02.vnp8x.gcp.mongodb-dev.net:27017 -P atlas-test
ID                         NAMESPACE            SUGGESTED INDEX
5f6a20b013ec1c5bf98fff5a   loadTest.saildrone   { timeUTC: 1 }
5f6a20b013ec1c5bf98fff5b   loadTest.saildrone   { id: 1, arrayOperation: 1, decimal: 1, nested.field: 1, quotedReservedWordField: 1, date: 1, binary: 1, embeddedArrayDocument: 1, embeddedDocument: 1, embeddedArray: 1, embeddedDocumentArray: 1, nullValue: 1, coordinates.latitude: 1 }
5f6a20b013ec1c5bf98fff5c   loadTest.saildrone   { RH_MEAN: 1 }

@andreaangiolillo andreaangiolillo marked this pull request as ready for review September 21, 2020 10:04
colm-quinn
colm-quinn reviewed Sep 21, 2020
View reviewed changes
internal/usage/usage.go
@@ -26,9 +26,12 @@ const (
Duration = "Length of time from the since parameter, in milliseconds, for which you want to receive results."
Tier = "Tier for each data-bearing server in the cluster."
NLog = "Maximum number of log lines to return."
Namespaces = "Namespaces from which to retrieve suggested slow query logs."
SlowQueryNamespaces = "Namespaces from which to retrieve suggested slow query logs."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

colm-quinn
colm-quinn previously approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny small typo np

@gssbzn
Copy link
Collaborator

gssbzn commented Sep 21, 2020

Also FYI I'm getting this

mongocli atlas performanceAdvisor suggestedIndexes ls --processName atlas-k11skw-shard-00-02.vnp8x.gcp.mongodb-dev.net:27017 -P dev
Error: processName is invalid because must be set

gssbzn
gssbzn requested changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there a little thing to improve on the spacing

internal/cli/performanceadvisor/suggestedindexes/list.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@andreaangiolillo andreaangiolillo merged commit 061c7b6 into master Sep 22, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-70067 branch September 22, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@colm-quinn colm-quinn colm-quinn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreaangiolillo @gssbzn @colm-quinn