Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-73287: allow to enable monitoring or backup agents #450

Merged
merged 2 commits into from
Sep 21, 2020
Merged

CLOUDP-73287: allow to enable monitoring or backup agents #450

merged 2 commits into from
Sep 21, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Sep 18, 2020 •
edited

Proposed changes

Jira ticket: CLOUDP-73287

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

$ mongocli om monitoring enable host2
Changes are being applied, please check http://mms:8080/v2/5f43a927c74f75134f354a7a#deployment/topology for status
$ mongocli om backup enable host2
Changes are being applied, please check http://mms:8080/v2/5f43a927c74f75134f354a7a#deployment/topology for status

andreaangiolillo
andreaangiolillo approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/cli/opsmanager/backup/backup.go
Comment on lines +30 to +35
cmd.AddCommand(
SnapshotsBuilder(),
RestoresBuilder(),
CheckpointsBuilder(),
EnableBuilder(),
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome back

@gssbzn gssbzn merged commit f41ef12 into master Sep 21, 2020
@gssbzn gssbzn deleted the CLOUDP-73287 branch September 21, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gssbzn @andreaangiolillo