Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-73729: mongocli ops-manager admin backup s3 describe #488

Merged
merged 7 commits into from
Oct 13, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-73729

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om admin backup s3 describe andrea.angiolillo.bucket -P ops
ID                         URI                         SSL     LOAD FACTOR   AUTH METHOD
andrea.angiolillo.bucket   mongodb://127.0.0.1:27017   false   50            KEYS
./bin/mongocli om admin backup s3 describe andrea.angiolillo.bucket -P ops -o json
{
  "id": "andrea.angiolillo.bucket",
  "uri": "mongodb://127.0.0.1:27017",
  "writeConcern": "ACKNOWLEDGED",
  "ssl": false,
  "assignmentEnabled": true,
  "encryptedCredentials": false,
  "loadFactor": 50,
  "awsAccessKey": "XXXXXX",
  "awsSecretKey": "XXXXXXXXXXX",
  "s3AuthMethod": "KEYS",
  "s3BucketEndpoint": "s3-eu-west-1.amazonaws.com",
  "s3BucketName": "andrea.angiolillo.bucket",
  "s3MaxConnections": 50,
  "disableProxyS3": true,
  "acceptedTos": true,
  "sseEnabled": false,
  "pathStyleAccessEnabled": false
}

gssbzn
gssbzn previously approved these changes Oct 13, 2020
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one small suggestion but we can do that later

internal/cli/opsmanager/admin/backup/s3/describe.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 51bf38b into master Oct 13, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-73729 branch October 13, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants