-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-69433: Milestone: Snapshot schedule #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits on copy
internal/usage/usage.go
Outdated
ClusterCheckpointIntervalMin = "Number of minutes between successive cluster checkpoints. Ops Manager may return values of 15, 30, or 60." | ||
SnapshotIntervalHours = "Number of hours between snapshots. Ops Manager may return values of 6, 8, 12, or 24." | ||
SnapshotRetentionDays = "Number of days to keep recent snapshots. Ops Manager may return values between 2 and 5, inclusive." | ||
WeeklySnapshotRetentionWeeks = "Number of weeks to retain weekly snapshots. Ops Manager may return values between 1 and 52, inclusive." | ||
PointInTimeWindowHours = "Number of hours in the past for which a point-in-time snapshot can be created." | ||
ReferenceHourOfDay = "Hour of the day to schedule snapshots using a 24 hour clock. Ops Manager may return values between 0 and 23, inclusive." | ||
ReferenceMinuteOfHour = "Minute of the hour to schedule snapshots. Ops Manager may return values between 0 and 59, inclusive." | ||
MonthlySnapshotRetentionMonths = "Number of months to retain monthly snapshots. Ops Manager may return values between 1 and 36, inclusive." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since these are all for cloud manager as well may want to say something like, Valid values: list of values
we have other examples of Valid values
here in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small nit on some flags being required
This reverts commit c0b96b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-69433
Checklist
make fmt
and formatted my codeFurther comments
DESCRIBE
UPDATE