Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-69435: Milestone: Feature control policies #498

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 14, 2020

Proposed changes

Jira ticket: CLOUDP-69435

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

LIST

./bin/mongocli om featurePolicies ls -P ops
NAME   SYSTEM ID   POLICY
test   22          DISABLE_USER_MANAGEMENT
test   22          EXTERNALLY_MANAGED_LOCK
./bin/mongocli om featurePolicies ls -P ops -o json
{
  "created": "2020-10-14T11:28:26Z",
  "updated": "2020-10-14T11:39:57Z",
  "externalManagementSystem": {
    "name": "test",
    "systemId": "22"
  },
  "policies": [
    {
      "policy": "DISABLE_USER_MANAGEMENT"
    },
    {
      "policy": "EXTERNALLY_MANAGED_LOCK"
    }
  ]
}

UPDATE

./bin/mongocli om featurePolicies update --name test --systemId 22 --policy EXTERNALLY_MANAGED_LOCK --policy DISABLE_USER_MANAGEMENT -P ops
Feature control policies updated.
./bin/mongocli om featurePolicies update --name test --systemId 22 --policy EXTERNALLY_MANAGED_LOCK --policy DISABLE_USER_MANAGEMENT -P ops -o json
{
  "created": "2020-10-14T11:28:26Z",
  "updated": "2020-10-14T12:00:04Z",
  "externalManagementSystem": {
    "name": "test",
    "systemId": "22"
  },
  "policies": [
    {
      "policy": "DISABLE_USER_MANAGEMENT"
    },
    {
      "policy": "EXTERNALLY_MANAGED_LOCK"
    }
  ]
}

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 30f590a into master Oct 14, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-69435 branch October 14, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants