CLOUDP-75269: Simplify PreRunE and PreRunEOrg #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gssbzn I would like to know what you think about this solution 🤔 ❓ |
gssbzn
reviewed
Oct 19, 2020
gssbzn
previously approved these changes
Oct 20, 2020
gssbzn
requested changes
Oct 20, 2020
gssbzn
previously approved these changes
Oct 20, 2020
| t.Fatalf("PreRunE() unexpected error %v\n", err) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func TestGlobalOpts_PreRunE(t *testing.T) { |
internal/cli/global_opts_test.go
Outdated
Comment on lines
69
to
75
| noErrorFunc := func() error { | ||
| return nil | ||
| } | ||
|
|
||
| errorFunc := func() error { | ||
| return errors.New("error") | ||
| } |
There was a problem hiding this comment.
[non-blocking] you could define each inside the test that uses it but this is not a blocking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-75269
Checklist
make fmtand formatted my codeFurther comments