-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-77747: [mongocli] Fix e2e tests for online archive #532
Conversation
@@ -36,12 +37,13 @@ func (opts *ListOpts) initStore() error { | |||
return err | |||
} | |||
|
|||
var listTemplate = `ID DATABASE COLLECTION STATE{{range .}} | |||
var listTemplate = `ID DATABASE COLLECTION STATE{{range .Results}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
results are now paginated and in a results array
f := strings.Split(p, ":") | ||
if len(f) != partitionParts { | ||
return nil, fmt.Errorf("partition should be fieldName:fieldType, got: %s", p) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field type is no longer exposed and is read only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay in reviewing.
Proposed changes
Jira ticket: CLOUDP-77747
Checklist
make fmt
and formatted my codeFurther comments