Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added featurePolicies e2e tests #533

Merged
merged 6 commits into from
Nov 27, 2020
Merged

Added featurePolicies e2e tests #533

merged 6 commits into from
Nov 27, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Nov 27, 2020 •
edited

Proposed changes

Added featurePolicies e2e tests

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

gssbzn
gssbzn previously approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's hear from colm in case we can improve this a littel

colm-quinn
colm-quinn requested changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should make sure parallel tests don't impact on each other.

Also I'd like to see disabledParams tested for the DISABLE_SET_MONGOD_CONFIG, as that is a use case for the operator and it would be useful if the cli can update the params.

If that feature doesn't work, then we should open a ticket.

gssbzn
gssbzn approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for those fixes

colm-quinn
colm-quinn approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates! Groot approves

@andreaangiolillo andreaangiolillo merged commit 86e6b9f into master Nov 27, 2020
@andreaangiolillo andreaangiolillo deleted the feature_policies_test branch November 27, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@colm-quinn colm-quinn colm-quinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreaangiolillo @gssbzn @colm-quinn