-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added featurePolicies e2e tests #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's hear from colm in case we can improve this a littel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should make sure parallel tests don't impact on each other.
Also I'd like to see disabledParams tested for the DISABLE_SET_MONGOD_CONFIG, as that is a use case for the operator and it would be useful if the cli can update the params.
If that feature doesn't work, then we should open a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for those fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the updates! Groot approves
Proposed changes
Added featurePolicies e2e tests
Checklist
make fmt
and formatted my codeFurther comments