CLOUDP-78654: Missing audit filter on convert #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Dec 9, 2020
| @@ -173,7 +173,7 @@ func createProject(projectName string) (string, error) { | |||
| cmd.Env = os.Environ() | |||
| resp, err := cmd.CombinedOutput() | |||
| if err != nil { | |||
| return "", err | |||
| return "", fmt.Errorf("%s (%w)", string(resp), err) | |||
There was a problem hiding this comment.
drive by debug, a tests was failing here and needed to see why
gssbzn
commented
Dec 9, 2020
| @@ -363,6 +363,7 @@ func (p *ProcessConfig) auditLog() *opsmngr.AuditLog { | |||
| Destination: p.auditLogDestination(), | |||
| Path: p.AuditLogPath, | |||
| Format: p.AuditLogFormat, | |||
| Filter: p.AuditLogFilter, | |||
There was a problem hiding this comment.
I missed this, the rest is tests
gssbzn
commented
Dec 9, 2020
| @@ -116,3 +113,166 @@ func TestNewReplicaSetProcessConfig(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, expected, result) | |||
| } | |||
|
|
|||
| func Test_newConfigRSProcess(t *testing.T) { | |||
There was a problem hiding this comment.
I added a test of ops manager -> mcli but not one mcli -> ops manager, so now we have both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-78654
Checklist
make fmtand formatted my codeFurther comments