Cloudp 84351 add agent images to dockerfile generator #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
approved these changes
Apr 8, 2021
| release = json.loads(f.read()) | ||
|
|
||
| return { | ||
| "template_path": "scripts/dev/templates/agent", |
There was a problem hiding this comment.
[q] why is this is shared if we always replace that?
There was a problem hiding this comment.
both agents have the same template path, but currently all the other images are just in "scripts/dev/templates"
There was a problem hiding this comment.
ah just seeing now you mean we replace it in both but with the same value - this is a mistake! Will correct it.
chatton
deleted the
CLOUDP-84351_add_agent_images_to_dockerfile_generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This PR moves the static agent Dockerfiles into templates for the dockerfile_generator
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).