Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Specifies that yearly backup schedule is available in CloudBackupSchedule #1015

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

oarbusi
Copy link
Contributor

@oarbusi oarbusi commented Apr 25, 2024

Proposed changes

Specifies that yearly backup schedule is available in CloudBackupSchedule. No changes are needed in implementation
Upgraded the SDK version being used

Link to any related issue(s): CLOUDP-237634

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

yearly backup policy created with:

{
  "desiredResourceState": {
    "Profile": "profile",
    "ProjectId": "projectId",
    "ClusterName": "clustername",
    "AutoExportEnabled": "False",
    "Export": {},
    "Policies": [
      {
        "PolicyItems": [
          {
            "FrequencyInterval": 6,
            "FrequencyType": "hourly",
            "RetentionUnit": "days",
            "RetentionValue": 7
          },
          {
            "FrequencyInterval": 1,
            "FrequencyType": "yearly",
            "RetentionUnit": "years",
            "RetentionValue": 2
          }
        ]
      }
    ],
    "ReferenceHourOfDay": "0",
    "ReferenceMinuteOfHour": "0",
    "RestoreWindowDays": "1",
    "UseOrgAndGroupNamesInExportPrefix": "true"
  },
  "providerLogGroupName": "mongodb-atlas-cloud-backup-schedule-logs",
  "previousResourceState": {}
}
Screenshot 2024-04-25 at 11 08 07

@oarbusi oarbusi requested a review from a team as a code owner April 25, 2024 09:17
@@ -40,7 +40,7 @@ _Update requires_: [No interruption](https://docs.aws.amazon.com/AWSCloudFormati

#### FrequencyType

Frequency associated with the backup policy item. One of the following values: hourly, daily, weekly or monthly.
Frequency associated with the backup policy item. One of the following values: hourly, daily, weekly, monthly or yearly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knit: keep the comma befor or. it's called the Oxford comma

hourly, daily, weekly, monthly, or yearly.

same for all

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Nice with SDK upgrade too 👏

@oarbusi oarbusi added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit d989ce0 Apr 25, 2024
31 checks passed
@oarbusi oarbusi deleted the CLOUDP-237634 branch April 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants