Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes defer closeResponse #1019

Merged
merged 2 commits into from
Apr 26, 2024
Merged

chore: Removes defer closeResponse #1019

merged 2 commits into from
Apr 26, 2024

Conversation

oarbusi
Copy link
Contributor

@oarbusi oarbusi commented Apr 26, 2024

Proposed changes

  • Remove defer closeResponse because this is already being done in the SDK
  • Refactor requests

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@oarbusi oarbusi requested a review from a team as a code owner April 26, 2024 09:49
lantoli
lantoli previously approved these changes Apr 26, 2024
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that linter is failing. otherwise great cleanup!

@oarbusi oarbusi added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 16df941 Apr 26, 2024
31 checks passed
@oarbusi oarbusi deleted the remove-closeresponse branch April 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants