MONGOID-5614 Document ffi dependency #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamis
approved these changes
May 5, 2023
| Add ``ffi`` to your Gemfile | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Mongo Ruby driver uses `ffi gem <https://github.com/ffi/ffi>`_ to call |
There was a problem hiding this comment.
Looks like a stray underscore character here. Also, probably only need backticks around the word "ffi" itself.
Also, grammatically: I'd insert "the" before "Mongo" and after "uses" (e.g. "The Mongo Ruby driver uses the ffi gem...").
There was a problem hiding this comment.
I cleaned this up. The trailing underscore is restructuredText link syntax (these aren't markdown files)
There was a problem hiding this comment.
Ah! Right. I keep forgetting about that.
There was a problem hiding this comment.
Thank you for the cleanup!
alexbevi
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.