Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow ruby to coerce field types when evaluating _matches? #5631

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Don't allow ruby to coerce field types when evaluating _matches? #5631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/mongoid/matcher/field_operator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ module FieldOperator
end

module_function def apply_comparison_operator(operator, left, right)
left.send(operator, right)
if left.is_a?(Numeric) && right.is_a?(Numeric)
left.send(operator, right)
elsif (left.is_a?(Date) || left.is_a?(Time)) && (right.is_a?(Date) || right.is_a?(Time))
left.send(operator, right)
elsif left.is_a?(String) && right.is_a?(String)
left.send(operator, right)
else
false
end
rescue ArgumentError, NoMethodError, TypeError
# We silence bogus comparison attempts, e.g. number to string
# comparisons.
Expand Down
Loading