Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio integration #20

Merged
merged 49 commits into from
Aug 26, 2015
Merged

asyncio integration #20

merged 49 commits into from
Aug 26, 2015

Conversation

asvetlov
Copy link
Contributor

@ajdavis please review

jettify and others added 30 commits July 5, 2015 19:37
Tail and SON manipulation tests
asyncio motor collections tests
port database test for asyncio
Port tests from test_motor_basic
@ajdavis
Copy link
Member

ajdavis commented Aug 15, 2015

@asvetlov this is incredibly exciting! I'll begin a review on Monday & Tuesday but I may not finish before I go on vacation, August 18-24. Is that ok or will it cause any delays for you?

@asvetlov
Copy link
Contributor Author

That's totally fine but I'll be glad to have quick partial feedback at least.
The most annoying issue is I don't know how avoid tornado install if I need asyncio only best way


# TODO: with stack_context.NullContext():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore this TODO so I remember to examine it? I'm concerned that if an exception-handler in one Tornado coroutine returns the socket to the pool, another Tornado coroutine that receives the socket will be in the wrong exception-handling context.

@ajdavis
Copy link
Member

ajdavis commented Aug 18, 2015

Gorgeous. I have a few minor quibbles. I expect I'll merge this soon after I return from vacation around August 25. Thanks so much.

@ajdavis
Copy link
Member

ajdavis commented Aug 25, 2015

I've opened issues for everything I need to do once this is merged, you can see them in the list of issues that MOTOR-40 depends on.

Shall I merge this now or is there additional work you'd like to do in your fork before I merge?

Of course, once I merge I invite you to continue fixing anything you'd like to fix, in separate pull requests.

ajdavis added a commit that referenced this pull request Aug 26, 2015
@ajdavis ajdavis merged commit cb7a7ca into mongodb:master Aug 26, 2015
@ajdavis
Copy link
Member

ajdavis commented Aug 26, 2015

Alright, I'm taking it. @asvetlov and @jettify a million thank yous! Please continue work if you need to change anything else.

@asvetlov
Copy link
Contributor Author

Cool!

On Wed, Aug 26, 2015 at 4:50 PM A. Jesse Jiryu Davis <
notifications@github.com> wrote:

Alright, I'm taking it. @asvetlov https://github.com/asvetlov and
@jettify https://github.com/jettify a million thank yous! Please
continue work if you need to change anything else.


Reply to this email directly or view it on GitHub
#20 (comment).

Thanks,
Andrew Svetlov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants